ios: quick question UI

ios/Packages/Sybil/Tests/SybilTests/SybilTests.swift

@@ -6,13 +6,22 @@ import Testing
 private struct MockClientCallSnapshot: Sendable {
     var listChats = 0
     var listSearches = 0
+    var createChat = 0
     var getChat = 0
     var getSearch = 0
     var getActiveRuns = 0
+    var runCompletionStream = 0
     var attachCompletionStream = 0
     var attachSearchStream = 0
 }
 
+private struct ChatCreateCallSnapshot: Sendable {
+    var title: String?
+    var provider: Provider?
+    var model: String?
+    var messages: [CompletionRequestMessage]?
+}
+
 private struct UnexpectedClientCall: Error {}
 
 private actor MockSybilClient: SybilAPIClienting {
@@ -24,6 +33,9 @@ private actor MockSybilClient: SybilAPIClienting {
     private let activeRunsResponse: ActiveRunsResponse
 
     private var snapshot = MockClientCallSnapshot()
+    private var lastCreateChatCall: ChatCreateCallSnapshot?
+    private var lastCompletionStreamBody: CompletionStreamRequest?
+    private var completionStreamEvents: [CompletionStreamEvent]?
     private var getChatDelayNanoseconds: UInt64 = 0
     private var getSearchDelayNanoseconds: UInt64 = 0
     private var completionStreamNetworkErrorMessage: String?
@@ -55,6 +67,19 @@ private actor MockSybilClient: SybilAPIClienting {
         snapshot
     }
 
+    func currentCreateChatCall() -> ChatCreateCallSnapshot? {
+        lastCreateChatCall
+    }
+
+    func currentCompletionStreamBody() -> CompletionStreamRequest? {
+        lastCompletionStreamBody
+    }
+
+    func setCompletionStreamEvents(_ events: [CompletionStreamEvent], delayNanoseconds: UInt64 = 0) {
+        completionStreamEvents = events
+        completionStreamDelayNanoseconds = delayNanoseconds
+    }
+
     func setCompletionStreamNetworkError(_ message: String, delayNanoseconds: UInt64 = 0) {
         completionStreamNetworkErrorMessage = message
         completionStreamDelayNanoseconds = delayNanoseconds
@@ -100,7 +125,19 @@ private actor MockSybilClient: SybilAPIClienting {
         return chatsResponse
     }
 
-    func createChat(title: String?) async throws -> ChatSummary {
+    func createChat(
+        title: String?,
+        provider: Provider?,
+        model: String?,
+        messages: [CompletionRequestMessage]?
+    ) async throws -> ChatSummary {
+        snapshot.createChat += 1
+        lastCreateChatCall = ChatCreateCallSnapshot(
+            title: title,
+            provider: provider,
+            model: model,
+            messages: messages
+        )
         if let createChatResponse {
             return createChatResponse
         }
@@ -167,12 +204,20 @@ private actor MockSybilClient: SybilAPIClienting {
         body: CompletionStreamRequest,
         onEvent: @escaping @Sendable (CompletionStreamEvent) async -> Void
     ) async throws {
+        snapshot.runCompletionStream += 1
+        lastCompletionStreamBody = body
         if completionStreamDelayNanoseconds > 0 {
             try await Task.sleep(nanoseconds: completionStreamDelayNanoseconds)
         }
         if let completionStreamNetworkErrorMessage {
             throw APIError.networkError(message: completionStreamNetworkErrorMessage)
         }
+        if let completionStreamEvents {
+            for event in completionStreamEvents {
+                await onEvent(event)
+            }
+            return
+        }
         throw UnexpectedClientCall()
     }
 
@@ -470,6 +515,117 @@ private func makeSearchDetail(id: String, date: Date, answer: String) -> SearchD
     await sendTask.value
 }
 
+@MainActor
+@Test func quickQuestionRunsNonPersistentCompletionStream() async throws {
+    let client = MockSybilClient()
+    await client.setCompletionStreamEvents([
+        .delta(CompletionStreamDelta(text: "Reset it from ")),
+        .done(CompletionStreamDone(text: "Reset it from Settings."))
+    ])
+    let viewModel = SybilViewModel(settings: testSettings(named: #function)) { _ in client }
+    viewModel.isAuthenticated = true
+    viewModel.isCheckingSession = false
+    viewModel.quickQuestionPrompt = "How do I reset my password?"
+
+    let task = viewModel.sendQuickQuestion()
+    await task?.value
+
+    let snapshot = await client.currentSnapshot()
+    let body = await client.currentCompletionStreamBody()
+    #expect(snapshot.runCompletionStream == 1)
+    #expect(body?.persist == false)
+    #expect(body?.chatId == nil)
+    #expect(body?.provider == .openai)
+    #expect(body?.messages.first?.role == .user)
+    #expect(body?.messages.first?.content == "How do I reset my password?")
+    #expect(viewModel.quickQuestionAnswerText == "Reset it from Settings.")
+    #expect(!viewModel.isQuickQuestionSending)
+}
+
+@MainActor
+@Test func quickQuestionConvertCreatesSeededChat() async throws {
+    let date = Date(timeIntervalSince1970: 1_700_000_250)
+    let chat = makeChatSummary(id: "quick-chat", date: date)
+    let detail = ChatDetail(
+        id: chat.id,
+        title: chat.title,
+        createdAt: chat.createdAt,
+        updatedAt: chat.updatedAt,
+        initiatedProvider: .openai,
+        initiatedModel: "gpt-4.1-mini",
+        lastUsedProvider: .openai,
+        lastUsedModel: "gpt-4.1-mini",
+        messages: [
+            Message(id: "quick-user", createdAt: date, role: .user, content: "How do I reset my password?", name: nil),
+            Message(id: "quick-assistant", createdAt: date, role: .assistant, content: "Reset it from Settings.", name: nil)
+        ]
+    )
+    let client = MockSybilClient(
+        chatsResponse: [chat],
+        chatDetails: [chat.id: detail],
+        createChatResponse: chat
+    )
+    let viewModel = SybilViewModel(settings: testSettings(named: #function)) { _ in client }
+    viewModel.isAuthenticated = true
+    viewModel.isCheckingSession = false
+    viewModel.quickQuestionSubmittedPrompt = "How do I reset my password?"
+    viewModel.quickQuestionSubmittedProvider = .openai
+    viewModel.quickQuestionSubmittedModel = "gpt-4.1-mini"
+    viewModel.quickQuestionMessages = [
+        Message(
+            id: "temp-assistant-quick",
+            createdAt: date,
+            role: .assistant,
+            content: "Reset it from Settings.",
+            name: nil
+        )
+    ]
+
+    let didConvert = await viewModel.convertQuickQuestionToChat()
+
+    let snapshot = await client.currentSnapshot()
+    let createCall = await client.currentCreateChatCall()
+    #expect(didConvert)
+    #expect(snapshot.createChat == 1)
+    #expect(createCall?.title == "How do I reset my password?")
+    #expect(createCall?.provider == .openai)
+    #expect(createCall?.model == "gpt-4.1-mini")
+    #expect(createCall?.messages?.map(\.role) == [.user, .assistant])
+    #expect(createCall?.messages?.map(\.content) == ["How do I reset my password?", "Reset it from Settings."])
+    #expect(viewModel.selectedItem == .chat("quick-chat"))
+    #expect(viewModel.quickQuestionPrompt.isEmpty)
+}
+
+@MainActor
+@Test func quickQuestionProviderAndModelSelectionPersistSeparately() async throws {
+    let defaults = UserDefaults(suiteName: #function)!
+    defaults.removePersistentDomain(forName: #function)
+    let settings = SybilSettingsStore(defaults: defaults)
+    settings.apiBaseURL = "http://127.0.0.1:8787"
+    let viewModel = SybilViewModel(settings: settings) { _ in MockSybilClient() }
+    viewModel.modelCatalog = [
+        .openai: ProviderModelInfo(models: ["gpt-4.1-mini", "gpt-4o"], loadedAt: nil, error: nil),
+        .anthropic: ProviderModelInfo(models: ["claude-3-5-sonnet-latest", "claude-3-haiku"], loadedAt: nil, error: nil)
+    ]
+
+    viewModel.setQuickQuestionProvider(.anthropic)
+    viewModel.setQuickQuestionModel("claude-3-haiku")
+
+    #expect(viewModel.quickQuestionProvider == .anthropic)
+    #expect(viewModel.quickQuestionModel == "claude-3-haiku")
+    #expect(settings.preferredProvider == .openai)
+
+    let reloadedSettings = SybilSettingsStore(defaults: defaults)
+    #expect(reloadedSettings.quickQuestionPreferredProvider == .anthropic)
+    #expect(reloadedSettings.quickQuestionPreferredModelByProvider[.anthropic] == "claude-3-haiku")
+    #expect(reloadedSettings.preferredProvider == .openai)
+
+    let reloadedViewModel = SybilViewModel(settings: reloadedSettings) { _ in MockSybilClient() }
+    #expect(reloadedViewModel.quickQuestionProvider == .anthropic)
+    #expect(reloadedViewModel.quickQuestionModel == "claude-3-haiku")
+    #expect(reloadedViewModel.provider == .openai)
+}
+
 @MainActor
 @Test func reconnectAttachesSelectedActiveChatStream() async throws {
     let date = Date(timeIntervalSince1970: 1_700_000_260)