refactor: remove retired agent provider integration

This commit is contained in:
2026-11-12 15:53:33 -08:00
parent d88018fd64
commit 91c7c0310e
42 changed files with 271 additions and 245 deletions
+6 -3
View File
@@ -58,7 +58,7 @@ test("mention invokes only the inline Agent, stores both sides, and replays by r
};
const first = await app.inject({ method: "POST", url: "/v1/chat-completions", headers: auth, payload: body });
assert.equal(first.statusCode, 200, first.body);
assert.equal(first.json().provider, "hermes-agent");
assert.equal(first.json().provider, "sybil-agent");
assert.equal(first.json().message.name, "Sybil Agent");
assert.equal(first.json().message.agentAside, true);
assert.equal(first.json().message.content, "Synthetic Sybil reply");
@@ -66,7 +66,7 @@ test("mention invokes only the inline Agent, stores both sides, and replays by r
const retry = await app.inject({ method: "POST", url: "/v1/chat-completions", headers: auth, payload: body });
assert.equal(retry.statusCode, 200, retry.body);
assert.equal(retry.json().provider, "hermes-agent");
assert.equal(retry.json().provider, "sybil-agent");
assert.equal(retry.json().message.name, "Sybil Agent");
assert.equal(retry.json().message.agentAside, true);
assert.equal(retry.json().message.content, "Synthetic Sybil reply");
@@ -224,9 +224,12 @@ test("streamed mention is idempotent and identifies the inline Agent", async ()
const retry = streamingApp.inject({ method: "POST", url: "/v1/chat-completions/stream", headers: auth, payload });
finish("Synthetic streamed reply");
const [firstResponse, retryResponse] = await Promise.all([first, retry]);
for (const response of [firstResponse, retryResponse]) {
const completedReplay = await streamingApp.inject({ method: "POST", url: "/v1/chat-completions/stream", headers: auth, payload });
for (const response of [firstResponse, retryResponse, completedReplay]) {
assert.equal(response.statusCode, 200, response.body);
assert.match(response.body, /"agentAside":true/);
assert.match(response.body, /"provider":"sybil-agent"/);
assert.match(response.body, /"model":"sybil-agent"/);
assert.match(response.body, /Synthetic streamed reply/);
}
assert.equal(calls, 1);
+2 -2
View File
@@ -125,13 +125,13 @@ test("plain Chat Completions stream does not send Sybil-managed tools", async ()
const events = await collectEvents(
streamWithChatCompletionsApi({
client: client as any,
model: "hermes-agent",
model: "grok-test",
messages: [{ role: "user", content: "Say hi" }],
enabledTools: [],
})
);
assert.equal(requestBody.model, "hermes-agent");
assert.equal(requestBody.model, "grok-test");
assert.equal(requestBody.stream, true);
assert.equal("tools" in requestBody, false);
assert.deepEqual(
+2 -7
View File
@@ -1,7 +1,7 @@
import assert from "node:assert/strict";
import test from "node:test";
import { env } from "../src/env.js";
import { describeProviderChatBackend, fetchProviderCatalogModels } from "../src/llm/provider-adapters.js";
import { describeProviderChatBackend, fetchProviderCatalogModels, listModelCatalogProviders } from "../src/llm/provider-adapters.js";
for (const { name, listedModels, expectedModels } of [
{
@@ -47,6 +47,7 @@ for (const { name, listedModels, expectedModels } of [
}
test("provider backend registry selects chat protocol and managed-tool mode", () => {
assert.deepEqual(listModelCatalogProviders(), ["openai", "anthropic", "xai", "gemini"]);
assert.deepEqual(describeProviderChatBackend("openai", []), {
provider: "openai",
protocol: "chat-completions",
@@ -77,10 +78,4 @@ test("provider backend registry selects chat protocol and managed-tool mode", ()
managedTools: true,
enabledTools: ["web_search"],
});
assert.deepEqual(describeProviderChatBackend("hermes-agent", ["web_search"]), {
provider: "hermes-agent",
protocol: "chat-completions",
managedTools: false,
enabledTools: [],
});
});
+21 -9
View File
@@ -1,14 +1,26 @@
import assert from "node:assert/strict";
import test from "node:test";
import { fromPrismaProvider, serializeProviderFields, toPrismaProvider } from "../src/llm/provider-ids.js";
import { parseProvider, serializeProviderFields } from "../src/llm/provider-ids.js";
import { PROVIDERS } from "../src/llm/types.js";
test("Hermes Agent provider id maps between API and Prisma enum forms", () => {
assert.equal(toPrismaProvider("hermes-agent"), "hermes_agent");
assert.equal(fromPrismaProvider("hermes_agent"), "hermes-agent");
assert.equal(toPrismaProvider("gemini"), "gemini");
assert.equal(fromPrismaProvider("gemini"), "gemini");
assert.deepEqual(serializeProviderFields({ initiatedProvider: "hermes_agent", lastUsedProvider: "gemini" }), {
initiatedProvider: "hermes-agent",
lastUsedProvider: "gemini",
test("only supported provider IDs can become active selections", () => {
for (const provider of PROVIDERS) assert.equal(parseProvider(provider), provider);
for (const provider of [null, undefined, "retired-provider", "sybil-agent", "toString", {}]) {
assert.equal(parseProvider(provider), null);
}
});
test("retired saved selections are cleared without changing historical call records", () => {
const record = {
initiatedProvider: "retired-provider", initiatedModel: "old-model",
lastUsedProvider: "gemini", lastUsedModel: "current-model",
calls: [{ provider: "retired-provider", model: "old-model", request: { provider: "retired-provider" } }],
};
assert.deepEqual(serializeProviderFields(record), {
initiatedProvider: null, initiatedModel: null,
lastUsedProvider: "gemini", lastUsedModel: "current-model",
calls: [{ provider: null, model: "old-model", request: { provider: "retired-provider" } }],
});
assert.equal(record.initiatedProvider, "retired-provider");
assert.equal(record.calls[0]!.provider, "retired-provider");
});
+80
View File
@@ -0,0 +1,80 @@
import assert from "node:assert/strict";
import { execFileSync } from "node:child_process";
import { mkdtempSync, rmSync } from "node:fs";
import { tmpdir } from "node:os";
import { dirname, join, resolve } from "node:path";
import test from "node:test";
import { fileURLToPath } from "node:url";
import Fastify from "fastify";
import sensible from "@fastify/sensible";
import { PROVIDERS } from "../src/llm/types.js";
const serverRoot = resolve(dirname(fileURLToPath(import.meta.url)), "..");
const databaseDir = mkdtempSync(join(tmpdir(), "sybil-provider-retirement-"));
process.env.DATABASE_URL = `file:${join(databaseDir, "test.db")}`;
process.env.ADMIN_TOKEN = "provider-retirement-test-token";
execFileSync(process.execPath, [join(serverRoot, "node_modules/prisma/build/index.js"), "migrate", "deploy"], {
cwd: serverRoot, env: { ...process.env, PRISMA_HIDE_UPDATE_MESSAGE: "1" }, stdio: "pipe",
});
const [{ registerRoutes }, { prisma }] = await Promise.all([import("../src/routes.js"), import("../src/db.js")]);
const app = Fastify({ logger: false });
await app.register(sensible);
await registerRoutes(app, { agentInlineInvoker: async () => { throw new Error("Unsupported requests must not invoke the Agent"); } });
await app.ready();
const auth = { authorization: "Bearer provider-retirement-test-token" };
test.after(async () => { await app.close(); await prisma.$disconnect(); rmSync(databaseDir, { recursive: true, force: true }); });
test("catalog and request validation expose only the remaining LLM providers", async () => {
const catalog = await app.inject({ method: "GET", url: "/v1/models", headers: auth });
assert.equal(catalog.statusCode, 200);
assert.deepEqual(Object.keys(catalog.json().providers), [...PROVIDERS]);
const before = await prisma.chat.count();
for (const provider of ["retired-provider", "sybil-agent"]) {
for (const url of ["/v1/chats", "/v1/chat-completions", "/v1/chat-completions/stream", "/v1/quick-questions/stream"]) {
const response = await app.inject({ method: "POST", url, headers: auth, payload: {
provider, model: "test-model", messages: [{ role: "user", content: "@sybil test" }], question: "test",
} });
assert.equal(response.statusCode, 400, `${url}: ${response.body}`);
}
}
assert.equal(await prisma.chat.count(), before);
assert.equal(await prisma.llmCall.count(), 0);
for (const provider of PROVIDERS) {
const response = await app.inject({ method: "POST", url: "/v1/chats", headers: auth, payload: { provider, model: "test-model" } });
assert.equal(response.statusCode, 200, response.body);
assert.equal(response.json().chat.lastUsedProvider, provider);
}
});
test("existing text provider IDs remain readable and forkable without relabeling history", async () => {
const chat = await prisma.chat.create({ data: {
title: "Archived provider conversation",
initiatedProvider: "retired-provider", initiatedModel: "archived-model",
lastUsedProvider: "retired-provider", lastUsedModel: "archived-model",
messages: { create: { role: "assistant", content: "Original saved answer", metadata: { clientRequestId: "old-request" } } },
calls: { create: { provider: "retired-provider", model: "archived-model", request: { provider: "retired-provider", clientRequestId: "old-request" }, latencyMs: 1 } },
}, include: { messages: true, calls: true } });
const detail = await app.inject({ method: "GET", url: `/v1/chats/${chat.id}`, headers: auth });
assert.equal(detail.statusCode, 200, detail.body);
const saved = detail.json().chat;
for (const key of ["initiatedProvider", "initiatedModel", "lastUsedProvider", "lastUsedModel"]) assert.equal(saved[key], null);
assert.equal(saved.messages[0].content, "Original saved answer");
assert.equal(saved.messages[0].metadata.generation, undefined);
assert.equal(saved.calls[0].provider, null);
assert.equal(saved.calls[0].request.provider, "retired-provider");
for (const url of ["/v1/chats", "/v1/workspace-items", "/v1/chats?limit=50"]) {
const response = await app.inject({ method: "GET", url, headers: auth });
assert.equal(response.statusCode, 200, `${url}: ${response.body}`);
const rows = response.json().chats ?? response.json().items;
assert.equal(rows.find((row: any) => row.id === chat.id).lastUsedProvider, null);
}
const fork = await app.inject({ method: "POST", url: `/v1/chats/${chat.id}/fork`, headers: auth, payload: {} });
assert.equal(fork.statusCode, 200, fork.body);
const forkDetail = await app.inject({ method: "GET", url: `/v1/chats/${fork.json().chat.id}`, headers: auth });
assert.equal(forkDetail.statusCode, 200, forkDetail.body);
assert.equal(forkDetail.json().chat.lastUsedProvider, null);
assert.equal(forkDetail.json().chat.messages[0].content, "Original saved answer");
const stored = await prisma.chat.findUniqueOrThrow({ where: { id: chat.id }, include: { calls: true } });
assert.equal(stored.lastUsedProvider, "retired-provider");
assert.equal(stored.calls[0]!.provider, "retired-provider");
});