refactor: remove retired agent provider integration

This commit is contained in:
2026-11-12 15:53:33 -08:00
parent d88018fd64
commit 91c7c0310e
42 changed files with 271 additions and 245 deletions
@@ -0,0 +1,39 @@
import Foundation
import Testing
@testable import Sybil
@Suite
struct ProviderTests {
@Test func selectableProvidersAndCatalogIgnoreRetiredIntegrations() throws {
#expect(Provider.allCases.map(\.rawValue) == ["openai", "anthropic", "xai", "gemini"])
let data = Data(#"{"providers":{"openai":{"models":["test-model"],"loadedAt":null,"error":null},"retired-provider":{"models":["old-model"],"loadedAt":null,"error":null}}}"#.utf8)
let catalog = try JSONDecoder().decode(ModelCatalogResponse.self, from: data)
#expect(catalog.providers.count == 1)
#expect(catalog.providers[.openai]?.models == ["test-model"])
}
@Test func historicalChatWithUnsupportedProviderStillDecodes() throws {
let data = Data(#"{"id":"old-chat","createdAt":0,"updatedAt":0,"initiatedProvider":"retired-provider","initiatedModel":"old-model","lastUsedProvider":"retired-provider","lastUsedModel":"old-model"}"#.utf8)
let chat = try JSONDecoder().decode(ChatSummary.self, from: data)
#expect(chat.initiatedProvider == nil)
#expect(chat.lastUsedProvider == nil)
#expect(chat.id == "old-chat")
}
@MainActor @Test func retiredSavedPreferencesUseSupportedDefaults() throws {
let suite = "ProviderTests.\(UUID().uuidString)"
let defaults = try #require(UserDefaults(suiteName: suite))
defer { defaults.removePersistentDomain(forName: suite) }
defaults.set("retired-provider", forKey: "sybil.ios.preferredProvider")
defaults.set("retired-provider", forKey: "sybil.ios.quickQuestionPreferredProvider")
defaults.set("kept-custom-model", forKey: "sybil.ios.preferredOpenAIModel")
let settings = SybilSettingsStore(defaults: defaults)
#expect(settings.preferredProvider == .openai)
#expect(settings.quickQuestionPreferredProvider == .openai)
#expect(settings.preferredModelByProvider[.openai] == "kept-custom-model")
#expect(settings.preferredModelByProvider.count == 4)
settings.persist()
#expect(defaults.string(forKey: "sybil.ios.preferredProvider") == "openai")
#expect(defaults.string(forKey: "sybil.ios.quickQuestionPreferredProvider") == "openai")
}
}
@@ -32,11 +32,14 @@ struct SybilInlineMentionTests {
@Test func streamMetaAcceptsOptionalAgentAsideFlag() throws {
let legacyData = Data(#"{"chatId":"chat-1","provider":"openai","model":"test-model"}"#.utf8)
let legacy = try JSONDecoder().decode(CompletionStreamMeta.self, from: legacyData)
#expect(legacy.provider == "openai")
#expect(legacy.agentAside == nil)
let asideData = Data(#"{"chatId":"chat-1","provider":"openai","model":"test-model","agentAside":true}"#.utf8)
let asideData = Data(#"{"chatId":"chat-1","provider":"sybil-agent","model":"sybil-agent","agentAside":true}"#.utf8)
let aside = try JSONDecoder().decode(CompletionStreamMeta.self, from: asideData)
#expect(aside.agentAside == true)
#expect(aside.provider == "sybil-agent")
#expect(Provider(rawValue: aside.provider) == nil)
}
@Test func asidePresentationUsesAssistantMetadata() {