Add Chromium fallback for failed playback
This commit is contained in:
@@ -0,0 +1,78 @@
|
||||
const test = require("node:test");
|
||||
const assert = require("node:assert/strict");
|
||||
const fs = require("node:fs/promises");
|
||||
const os = require("node:os");
|
||||
const path = require("node:path");
|
||||
const { ChromiumFallback } = require("../build/ChromiumFallback");
|
||||
|
||||
const waitFor = async (predicate) => {
|
||||
const deadline = Date.now() + 3000;
|
||||
while (Date.now() < deadline) {
|
||||
if (await predicate()) return;
|
||||
await new Promise((resolve) => setTimeout(resolve, 20));
|
||||
}
|
||||
throw new Error("timed out waiting for subprocess fixture");
|
||||
};
|
||||
|
||||
test("uses isolated profile and safe argv; stop kills only its process and cleans profile", async () => {
|
||||
const fixture = await fs.mkdtemp(path.join(os.tmpdir(), "queuecube-test-"));
|
||||
const argsFile = path.join(fixture, "argv.json");
|
||||
const executable = path.join(fixture, "fake-chrome.js");
|
||||
await fs.writeFile(executable, `#!/usr/bin/env node\nconst fs=require('fs'); fs.writeFileSync(${JSON.stringify(argsFile)}, JSON.stringify(process.argv.slice(2))); setInterval(()=>{},1000);\n`);
|
||||
await fs.chmod(executable, 0o700);
|
||||
const browser = new ChromiumFallback(() => undefined, executable);
|
||||
const url = "https://example.test/?x=1; touch /tmp/should-not-exist";
|
||||
|
||||
try {
|
||||
assert.equal(await browser.start(url, () => true), true);
|
||||
await waitFor(async () => { try { await fs.access(argsFile); return true; } catch { return false; } });
|
||||
const args = JSON.parse(await fs.readFile(argsFile, "utf8"));
|
||||
assert.equal(args.at(-1), url);
|
||||
assert.ok(args.some((arg) => arg.startsWith("--user-data-dir=")));
|
||||
assert.ok(args.includes("--kiosk"));
|
||||
assert.ok(!args.some((arg) => /no-sandbox|disable-web-security|ignore-certificate/i.test(arg)));
|
||||
const profilePath = args.find((arg) => arg.startsWith("--user-data-dir=")).split("=", 2)[1];
|
||||
await browser.stop();
|
||||
assert.equal(browser.isRunning, false);
|
||||
await assert.rejects(fs.access(profilePath));
|
||||
} finally {
|
||||
await browser.stop();
|
||||
await fs.rm(fixture, { recursive: true, force: true });
|
||||
}
|
||||
});
|
||||
|
||||
test("canceled startup cleans its profile without spawning", async () => {
|
||||
const browser = new ChromiumFallback(() => undefined, "/bin/false");
|
||||
assert.equal(await browser.start("https://example.test/", () => false), false);
|
||||
assert.equal(browser.isRunning, false);
|
||||
});
|
||||
|
||||
test("cancellation during process startup stops the late process and removes its profile", async () => {
|
||||
const fixture = await fs.mkdtemp(path.join(os.tmpdir(), "queuecube-race-test-"));
|
||||
const executable = path.join(fixture, "fake-chrome.js");
|
||||
await fs.writeFile(executable, "#!/usr/bin/env node\nsetInterval(()=>{},1000);\n");
|
||||
await fs.chmod(executable, 0o700);
|
||||
const browser = new ChromiumFallback(() => undefined, executable);
|
||||
const cleanedProfiles = [];
|
||||
const removeProfile = browser.removeProfile.bind(browser);
|
||||
browser.removeProfile = async (profile) => { cleanedProfiles.push(profile); await removeProfile(profile); };
|
||||
let checks = 0;
|
||||
try {
|
||||
assert.equal(await browser.start("https://example.test/race", () => ++checks === 1), false);
|
||||
assert.equal(checks, 2, "the request became stale after process startup");
|
||||
await waitFor(async () => {
|
||||
if (!cleanedProfiles.length) return false;
|
||||
try { await fs.access(cleanedProfiles[0]); return false; } catch { return true; }
|
||||
});
|
||||
assert.equal(browser.isRunning, false);
|
||||
} finally {
|
||||
await browser.stop();
|
||||
await fs.rm(fixture, { recursive: true, force: true });
|
||||
}
|
||||
});
|
||||
|
||||
test("missing browser executable reports startup failure and clears ownership", async () => {
|
||||
const browser = new ChromiumFallback(() => undefined, "/definitely/missing/queuecube-chrome");
|
||||
await assert.rejects(browser.start("https://example.test/", () => true), /ENOENT/);
|
||||
assert.equal(browser.isRunning, false);
|
||||
});
|
||||
@@ -0,0 +1,103 @@
|
||||
const test = require("node:test");
|
||||
const assert = require("node:assert/strict");
|
||||
const { MediaPlayer } = require("../build/MediaPlayer");
|
||||
|
||||
const makePlayer = (url = "https://example.test/watch?v=abc") => {
|
||||
const player = Object.create(MediaPlayer.prototype);
|
||||
const starts = [];
|
||||
let stops = 0;
|
||||
Object.assign(player, {
|
||||
eventSubscribers: [],
|
||||
playbackErrors: new Map(),
|
||||
currentFile: url,
|
||||
lastLoadCandidate: url,
|
||||
activeEntryId: 42,
|
||||
currentMediaTitle: null,
|
||||
currentPlaybackMetadata: {},
|
||||
dataBuffer: "",
|
||||
loadGeneration: 4,
|
||||
fallbackCandidates: new Map([[url, 4]]),
|
||||
browserUrl: null,
|
||||
browserFallback: {
|
||||
isRunning: false,
|
||||
start: async (requestedUrl, isCurrent) => {
|
||||
starts.push(requestedUrl);
|
||||
if (!isCurrent()) return false;
|
||||
player.browserFallback.isRunning = true;
|
||||
return true;
|
||||
},
|
||||
stop: async () => {
|
||||
stops += 1;
|
||||
player.browserFallback.isRunning = false;
|
||||
},
|
||||
},
|
||||
writeCommand: async () => ({ data: [{ id: 42, filename: url }] }),
|
||||
});
|
||||
return { player, starts, get stops() { return stops; } };
|
||||
};
|
||||
|
||||
const begin = (player, entryId = 42) => player.receiveData(`${JSON.stringify({ event: "start-file", playlist_entry_id: entryId })}\n`);
|
||||
const send = (player, event) => player.receiveData(`${JSON.stringify({ event: "end-file", file: player.currentFile, playlist_entry_id: player.activeEntryId, ...event })}\n`);
|
||||
const settle = () => new Promise((resolve) => setImmediate(resolve));
|
||||
|
||||
test("successful MPV completion does not start fallback", async () => {
|
||||
const { player, starts } = makePlayer();
|
||||
begin(player);
|
||||
send(player, { reason: "eof" });
|
||||
await settle();
|
||||
assert.deepEqual(starts, []);
|
||||
});
|
||||
|
||||
test("actual MPV error opens the exact original URL and mirrors indeterminate state", async () => {
|
||||
const url = "https://example.test/watch?v=x&next=1;touch%20/tmp/nope";
|
||||
const { player, starts } = makePlayer(url);
|
||||
begin(player);
|
||||
send(player, { reason: "error", file_error: "demux failed" });
|
||||
await settle();
|
||||
assert.deepEqual(starts, [url]);
|
||||
assert.equal(player.browserUrl, url);
|
||||
assert.equal((await player.getNowPlaying()).filename, url);
|
||||
assert.equal(await player.getPauseState(), false);
|
||||
assert.equal(await player.getIdle(), false);
|
||||
assert.equal(await player.getTimePosition(), null);
|
||||
assert.equal(await player.getDuration(), null);
|
||||
assert.equal(await player.getSeekable(), false);
|
||||
});
|
||||
|
||||
test("EOF and user stop, cancel, replacement, or stale queue events do not fallback", async () => {
|
||||
const eof = makePlayer();
|
||||
send(eof.player, { reason: "eof" });
|
||||
|
||||
for (const action of ["stop", "cancel", "replacement", "shutdown"]) {
|
||||
const replacementUrl = "https://example.test/replacement";
|
||||
const { player, starts } = makePlayer(replacementUrl);
|
||||
player.writeCommand = async () => ({});
|
||||
player.fetchMetadataAndNotify = async () => undefined;
|
||||
if (action === "shutdown") await player.shutdown();
|
||||
else if (action === "stop") await player.stop();
|
||||
else if (action === "replacement") await player.replace(replacementUrl);
|
||||
else await player.cancelBrowserFallback();
|
||||
begin(player);
|
||||
send(player, { reason: "error" });
|
||||
await settle();
|
||||
assert.deepEqual(starts, [], `${action} must invalidate the callback`);
|
||||
}
|
||||
|
||||
const stale = makePlayer();
|
||||
stale.player.currentFile = "https://example.test/next";
|
||||
stale.player.activeEntryId = 43;
|
||||
send(stale.player, { reason: "error", playlist_entry_id: 42 });
|
||||
await settle();
|
||||
assert.deepEqual(stale.starts, []);
|
||||
});
|
||||
|
||||
test("fallback startup failure leaves MPV state usable", async () => {
|
||||
const { player, starts } = makePlayer();
|
||||
player.browserFallback.start = async () => { throw new Error("chromium missing"); };
|
||||
begin(player);
|
||||
send(player, { reason: "error" });
|
||||
await settle();
|
||||
assert.equal(player.browserUrl, null);
|
||||
assert.deepEqual(starts, []);
|
||||
assert.equal(player.playbackErrors.get(player.currentFile), "Unknown playback error");
|
||||
});
|
||||
@@ -0,0 +1,2 @@
|
||||
require("./ChromiumFallback.test.cjs");
|
||||
require("./MediaPlayerFallback.test.cjs");
|
||||
Reference in New Issue
Block a user