[core] bump to 1.3.2

.gitea/scripts/prepare-rpm-release-assets.sh

@@ -0,0 +1,61 @@
+#!/usr/bin/env bash
+set -euo pipefail
+
+: "${RELEASE_TAG:?Missing RELEASE_TAG}"
+: "${TAG_PREFIX:?Missing TAG_PREFIX}"
+: "${ASSETS_DIR:?Missing ASSETS_DIR}"
+: "${RPM_BINARY_DIR:?Missing RPM_BINARY_DIR}"
+: "${RPM_BINARY_PATTERN_PREFIX:?Missing RPM_BINARY_PATTERN_PREFIX}"
+: "${RPM_DISTRO_NAME:?Missing RPM_DISTRO_NAME}"
+: "${RPM_DISTRO_VERSION:?Missing RPM_DISTRO_VERSION}"
+: "${GITHUB_ENV:?Missing GITHUB_ENV}"
+
+version="${RELEASE_TAG#${TAG_PREFIX}}"
+if [[ -z "$version" || "$version" == "$RELEASE_TAG" ]]; then
+  echo "Expected tag in the form ${TAG_PREFIX}{version}, got: $RELEASE_TAG" >&2
+  exit 1
+fi
+
+if [[ -n "${EXPECTED_VERSION:-}" && "$EXPECTED_VERSION" != "$version" ]]; then
+  echo "Release tag version ($version) does not match expected package version ($EXPECTED_VERSION)." >&2
+  exit 1
+fi
+
+rm -rf "$ASSETS_DIR"
+mkdir -p "$ASSETS_DIR"
+
+found=0
+binary_pattern="${RPM_BINARY_PATTERN_PREFIX}${version}-*.rpm"
+if [[ -d "$RPM_BINARY_DIR" ]]; then
+  find_cmd=(
+    find "$RPM_BINARY_DIR" -type f -name "$binary_pattern"
+  )
+  while IFS= read -r exclude; do
+    [[ -n "$exclude" ]] || continue
+    find_cmd+=( ! -name "$exclude" )
+  done <<< "${RPM_BINARY_EXCLUDE_PATTERNS:-}"
+  find_cmd+=( -exec cp '{}' "$ASSETS_DIR/" ';' )
+  "${find_cmd[@]}"
+fi
+
+if find "$ASSETS_DIR" -maxdepth 1 -type f -name '*.rpm' | grep -q .; then
+  found=1
+fi
+
+if [[ -n "${RPM_SOURCE_DIR:-}" && -n "${RPM_SOURCE_PATTERN_PREFIX:-}" && -d "$RPM_SOURCE_DIR" ]]; then
+  source_pattern="${RPM_SOURCE_PATTERN_PREFIX}${version}-*.src.rpm"
+  find "$RPM_SOURCE_DIR" -type f -name "$source_pattern" -exec cp '{}' "$ASSETS_DIR/" ';'
+fi
+
+if [[ "$found" -ne 1 ]]; then
+  echo "No RPM artifacts were produced." >&2
+  exit 1
+fi
+
+package_group="${RPM_PACKAGE_GROUP:-${RPM_DISTRO_NAME}/${RPM_DISTRO_VERSION}}"
+
+{
+  printf 'RELEASE_VERSION=%s\n' "$version"
+  printf 'RELEASE_ASSETS_DIR=%s\n' "$ASSETS_DIR"
+  printf 'RPM_PACKAGE_GROUP=%s\n' "$package_group"
+} >> "$GITHUB_ENV"

.gitea/scripts/upload-rpm-packages.sh

@@ -0,0 +1,65 @@
+#!/usr/bin/env bash
+set -euo pipefail
+
+: "${GITEA_SERVER_URL:?Missing GITEA_SERVER_URL}"
+: "${GITEA_REPOSITORY_OWNER:?Missing GITEA_REPOSITORY_OWNER}"
+: "${RELEASE_ASSETS_DIR:?Missing RELEASE_ASSETS_DIR}"
+
+owner="${GITEA_REPOSITORY_OWNER}"
+package_user="${RPM_PACKAGE_USERNAME:-${GITEA_REPOSITORY_OWNER}}"
+token="${RPM_PACKAGE_TOKEN:-}"
+group="${RPM_PACKAGE_GROUP:-}"
+
+if [[ -z "$package_user" ]]; then
+  echo "Missing package upload username. Set repository or organization variable RPM_PACKAGE_USERNAME." >&2
+  exit 1
+fi
+
+if [[ -z "$token" ]]; then
+  echo "Missing package upload token. Set repository or organization secret RPM_PACKAGE_TOKEN." >&2
+  exit 1
+fi
+
+upload_url="${GITEA_SERVER_URL%/}/api/packages/${owner}/rpm"
+if [[ -n "$group" ]]; then
+  upload_url="${upload_url}/${group}"
+fi
+upload_url="${upload_url}/upload"
+
+shopt -s nullglob
+found_rpm=0
+for rpm in "$RELEASE_ASSETS_DIR"/*.rpm; do
+  case "$rpm" in
+    *.src.rpm)
+      continue
+      ;;
+  esac
+
+  found_rpm=1
+  http_code="$(curl --silent --show-error \
+    --write-out '%{http_code}' \
+    --output /tmp/package-upload-response \
+    --user "${package_user}:${token}" \
+    --upload-file "$rpm" \
+    "$upload_url")"
+
+  case "$http_code" in
+    201)
+      echo "Uploaded $(basename "$rpm") to the RPM package registry."
+      ;;
+    409)
+      echo "Package already exists for $(basename "$rpm"); skipping duplicate upload."
+      ;;
+    *)
+      echo "Failed to upload $(basename "$rpm") to $upload_url (HTTP $http_code)." >&2
+      cat /tmp/package-upload-response >&2 || true
+      exit 1
+      ;;
+  esac
+done
+shopt -u nullglob
+
+if [[ "$found_rpm" -ne 1 ]]; then
+  echo "No binary RPM artifacts were found to upload." >&2
+  exit 1
+fi

.gitea/workflows/android-release.yaml

@@ -14,7 +14,7 @@ jobs:
     runs-on: ubuntu-latest
 
     steps:
-      # Gitea's default act_runner labels map ubuntu-22.04 to node:16-bullseye,
+      # Gitea's default act_runner labels map ubuntu-latest to node:16-bullseye,
       # so keep the GitHub-hosted actions on their Node 16-compatible v3 line.
       - name: Install system dependencies
         run: |
@@ -37,22 +37,105 @@ jobs:
           unzip -q /tmp/android-commandlinetools.zip -d /tmp/android-commandlinetools
           mv /tmp/android-commandlinetools/cmdline-tools "$ANDROID_SDK_ROOT/cmdline-tools/latest"
 
+          # sdkmanager exits successfully once it has consumed all input, which
+          # causes `yes` to receive SIGPIPE and return 141 under `pipefail`.
+          set +o pipefail
           yes | "$ANDROID_SDK_ROOT/cmdline-tools/latest/bin/sdkmanager" --sdk_root="$ANDROID_SDK_ROOT" --licenses
+          set -o pipefail
+
           "$ANDROID_SDK_ROOT/cmdline-tools/latest/bin/sdkmanager" --sdk_root="$ANDROID_SDK_ROOT" \
             "platform-tools" \
             "build-tools;33.0.1" \
             "platforms;android-33"
 
+      - name: Prepare Android signing config
+        env:
+          ANDROID_RELEASE_KEYSTORE_B64: ${{ secrets.ANDROID_RELEASE_KEYSTORE_B64 }}
+          ORG_GRADLE_PROJECT_RELEASE_STORE_PASSWORD: ${{ secrets.ANDROID_RELEASE_STORE_PASSWORD }}
+          ORG_GRADLE_PROJECT_RELEASE_KEY_ALIAS: ${{ secrets.ANDROID_RELEASE_KEY_ALIAS }}
+          ORG_GRADLE_PROJECT_RELEASE_KEY_PASSWORD: ${{ secrets.ANDROID_RELEASE_KEY_PASSWORD }}
+        run: |
+          set -eu
+
+          : "${ANDROID_RELEASE_KEYSTORE_B64:?Missing secret ANDROID_RELEASE_KEYSTORE_B64}"
+          : "${ORG_GRADLE_PROJECT_RELEASE_STORE_PASSWORD:?Missing secret ANDROID_RELEASE_STORE_PASSWORD}"
+          : "${ORG_GRADLE_PROJECT_RELEASE_KEY_ALIAS:?Missing secret ANDROID_RELEASE_KEY_ALIAS}"
+          : "${ORG_GRADLE_PROJECT_RELEASE_KEY_PASSWORD:?Missing secret ANDROID_RELEASE_KEY_PASSWORD}"
+
+          keystore_path="${{ gitea.workspace }}/android-release.keystore"
+          printf '%s' "$ANDROID_RELEASE_KEYSTORE_B64" | base64 -d > "$keystore_path"
+          chmod 600 "$keystore_path"
+
+          printf 'ORG_GRADLE_PROJECT_RELEASE_STORE_FILE=%s\n' "$keystore_path" >> "$GITHUB_ENV"
+          printf 'ORG_GRADLE_PROJECT_RELEASE_STORE_PASSWORD=%s\n' "$ORG_GRADLE_PROJECT_RELEASE_STORE_PASSWORD" >> "$GITHUB_ENV"
+          printf 'ORG_GRADLE_PROJECT_RELEASE_KEY_ALIAS=%s\n' "$ORG_GRADLE_PROJECT_RELEASE_KEY_ALIAS" >> "$GITHUB_ENV"
+          printf 'ORG_GRADLE_PROJECT_RELEASE_KEY_PASSWORD=%s\n' "$ORG_GRADLE_PROJECT_RELEASE_KEY_PASSWORD" >> "$GITHUB_ENV"
+
       - name: Build Android release APKs
         working-directory: android
         run: ./gradlew assembleRelease
 
-      - name: Upload release artifacts
+      - name: Prepare release assets
-        uses: actions/upload-artifact@v3
+        env:
+          RELEASE_TAG: ${{ github.ref_name }}
+        run: |
+          set -eu
+
+          version="${RELEASE_TAG#release/android/}"
+          if [ -z "$version" ] || [ "$version" = "$RELEASE_TAG" ]; then
+            echo "Expected tag in the form release/android/{version}, got: $RELEASE_TAG" >&2
+            exit 1
+          fi
+
+          assets_dir="${{ gitea.workspace }}/release-assets/android"
+          rm -rf "$assets_dir"
+          mkdir -p "$assets_dir"
+
+          found_apk=0
+          for apk in android/app/build/outputs/apk/release/*.apk; do
+            if [ ! -e "$apk" ]; then
+              continue
+            fi
+
+            found_apk=1
+            base="$(basename "$apk")"
+
+            case "$base" in
+              app-*-release*.apk)
+                arch="${base#app-}"
+                arch="${arch%%-release*}"
+                ;;
+              app-release*.apk)
+                arch="universal"
+                ;;
+              *)
+                echo "Unexpected APK filename: $base" >&2
+                exit 1
+                ;;
+            esac
+
+            cp "$apk" "$assets_dir/kordophone-${arch}-${version}.apk"
+          done
+
+          if [ "$found_apk" -ne 1 ]; then
+            echo "No release APKs were produced." >&2
+            exit 1
+          fi
+
+          {
+            printf 'RELEASE_VERSION=%s\n' "$version"
+            printf 'RELEASE_ASSETS_DIR=%s\n' "$assets_dir"
+          } >> "$GITHUB_ENV"
+
+      - name: Create Gitea release
+        uses: https://gitea.com/actions/gitea-release-action@v1
         with:
-          name: kordophone-android-release
+          name: Kordophone Android ${{ env.RELEASE_VERSION }}
-          path: |
+          tag_name: ${{ github.ref_name }}
-            android/app/build/outputs/apk/release/*.apk
+          target_commitish: ${{ github.sha }}
-            android/app/build/outputs/apk/release/output-metadata.json
+          files: |
-          if-no-files-found: error
+            ${{ env.RELEASE_ASSETS_DIR }}/*.apk
-          retention-days: 90
+
+      - name: Clean up signing material
+        if: ${{ always() }}
+        run: rm -f "${{ gitea.workspace }}/android-release.keystore"

.gitea/workflows/core-rpm-release.yaml

@@ -0,0 +1,112 @@
+name: Core RPM Release
+
+on:
+  push:
+    tags:
+      - 'release/core/*'
+
+permissions:
+  code: read
+  releases: write
+  packages: write
+
+env:
+  RPM_DISTRO_NAME: fedora
+  RPM_DISTRO_VERSION: '43'
+
+jobs:
+  build-core-rpm-release:
+    runs-on: ubuntu-latest
+    container:
+      image: fedora:43
+
+    steps:
+      # Build inside Fedora so the RPM package repository grouping matches the
+      # Fedora release we publish to.
+      - name: Install system dependencies
+        run: |
+          set -eu
+          dnf install -y \
+            ca-certificates \
+            curl \
+            gcc \
+            gcc-c++ \
+            git \
+            make \
+            nodejs \
+            openssl-devel \
+            pkg-config \
+            python3 \
+            rpm-build \
+            sqlite-devel \
+            dbus-devel \
+            systemd-devel
+          dnf clean all
+
+      - name: Install Rust toolchain
+        run: |
+          set -eu
+          curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh -s -- -y
+          echo "/root/.cargo/bin" >> "$GITHUB_PATH"
+
+      - name: Install cargo-generate-rpm
+        run: cargo install cargo-generate-rpm
+
+      - name: Check out repository code
+        uses: actions/checkout@v3
+        with:
+          fetch-depth: 0
+
+      - name: Build Core RPM
+        working-directory: core
+        run: make rpm
+
+      - name: Read Core Package Version
+        run: |
+          set -eu
+          version="$(awk -F ' = ' '
+            $0 == "[package]" { in_pkg = 1; next }
+            /^\[/ { in_pkg = 0 }
+            in_pkg && $1 == "version" {
+              gsub(/"/, "", $2)
+              print $2
+              exit
+            }
+          ' core/kordophoned/Cargo.toml)"
+          if [ -z "$version" ]; then
+            echo "Could not determine kordophoned package version from core/kordophoned/Cargo.toml." >&2
+            exit 1
+          fi
+          printf 'CORE_PACKAGE_VERSION=%s\n' "$version" >> "$GITHUB_ENV"
+
+      - name: Prepare release assets
+        env:
+          RELEASE_TAG: ${{ github.ref_name }}
+          TAG_PREFIX: release/core/
+          ASSETS_DIR: ${{ gitea.workspace }}/release-assets/core
+          RPM_BINARY_DIR: ${{ gitea.workspace }}/core/target/generate-rpm
+          RPM_BINARY_PATTERN_PREFIX: kordophoned-
+          RPM_PACKAGE_GROUP: ${{ vars.RPM_PACKAGE_GROUP }}
+          RPM_DISTRO_NAME: ${{ env.RPM_DISTRO_NAME }}
+          RPM_DISTRO_VERSION: ${{ env.RPM_DISTRO_VERSION }}
+          EXPECTED_VERSION: ${{ env.CORE_PACKAGE_VERSION }}
+        run: ./.gitea/scripts/prepare-rpm-release-assets.sh
+
+      - name: Upload RPMs to Gitea package registry
+        env:
+          GITEA_SERVER_URL: ${{ gitea.server_url }}
+          GITEA_REPOSITORY_OWNER: ${{ gitea.repository_owner }}
+          RPM_PACKAGE_GROUP: ${{ env.RPM_PACKAGE_GROUP }}
+          RPM_PACKAGE_TOKEN: ${{ secrets.RPM_PACKAGE_TOKEN }}
+          RPM_PACKAGE_USERNAME: ${{ vars.RPM_PACKAGE_USERNAME }}
+          RELEASE_ASSETS_DIR: ${{ env.RELEASE_ASSETS_DIR }}
+        run: ./.gitea/scripts/upload-rpm-packages.sh
+
+      - name: Create Gitea release
+        uses: https://gitea.com/actions/gitea-release-action@v1
+        with:
+          name: Kordophoned Core ${{ env.RELEASE_VERSION }}
+          tag_name: ${{ github.ref_name }}
+          target_commitish: ${{ github.sha }}
+          files: |
+            ${{ env.RELEASE_ASSETS_DIR }}/*.rpm

.gitea/workflows/gtk-rpm-release.yaml

@@ -0,0 +1,97 @@
+name: GTK RPM Release
+
+on:
+  push:
+    tags:
+      - 'release/gtk/*'
+
+permissions:
+  code: read
+  releases: write
+  packages: write
+
+env:
+  RPM_DISTRO_NAME: fedora
+  RPM_DISTRO_VERSION: '43'
+
+jobs:
+  build-gtk-rpm-release:
+    runs-on: ubuntu-latest
+    container:
+      image: fedora:43
+
+    steps:
+      # The default Gitea runner image is Debian-based. Build the GTK RPM in a
+      # Fedora container so rpmbuild and the RPM build dependencies match the
+      # existing local packaging environment.
+      - name: Install system dependencies
+        run: |
+          set -eu
+          dnf install -y \
+            ca-certificates \
+            curl \
+            gcc \
+            git \
+            ImageMagick \
+            libadwaita-devel \
+            libgee-devel \
+            libsecret-devel \
+            make \
+            meson \
+            ninja-build \
+            nodejs \
+            pkgconfig \
+            python3 \
+            redhat-rpm-config \
+            rpm-build \
+            rpmdevtools \
+            gtk4-devel \
+            glib2-devel \
+            vala
+          dnf clean all
+          rpmdev-setuptree
+
+      - name: Check out repository code
+        uses: actions/checkout@v3
+        with:
+          fetch-depth: 0
+
+      - name: Build GTK RPMs
+        working-directory: gtk
+        run: make rpm
+
+      - name: Prepare release assets
+        env:
+          RELEASE_TAG: ${{ github.ref_name }}
+          TAG_PREFIX: release/gtk/
+          ASSETS_DIR: ${{ gitea.workspace }}/release-assets/gtk
+          RPM_BINARY_DIR: /root/rpmbuild/RPMS
+          RPM_BINARY_PATTERN_PREFIX: kordophone-
+          RPM_BINARY_EXCLUDE_PATTERNS: |
+            *-debuginfo-*
+            *-debugsource-*
+          RPM_PACKAGE_GROUP: ${{ vars.RPM_PACKAGE_GROUP }}
+          RPM_SOURCE_DIR: /root/rpmbuild/SRPMS
+          RPM_SOURCE_PATTERN_PREFIX: kordophone-
+          RPM_DISTRO_NAME: ${{ env.RPM_DISTRO_NAME }}
+          RPM_DISTRO_VERSION: ${{ env.RPM_DISTRO_VERSION }}
+        run: ./.gitea/scripts/prepare-rpm-release-assets.sh
+
+      - name: Upload RPMs to Gitea package registry
+        env:
+          GITEA_SERVER_URL: ${{ gitea.server_url }}
+          GITEA_REPOSITORY_OWNER: ${{ gitea.repository_owner }}
+          RPM_PACKAGE_GROUP: ${{ env.RPM_PACKAGE_GROUP }}
+          RPM_PACKAGE_TOKEN: ${{ secrets.RPM_PACKAGE_TOKEN }}
+          RPM_PACKAGE_USERNAME: ${{ vars.RPM_PACKAGE_USERNAME }}
+          RELEASE_ASSETS_DIR: ${{ env.RELEASE_ASSETS_DIR }}
+        run: ./.gitea/scripts/upload-rpm-packages.sh
+
+      - name: Create Gitea release
+        uses: https://gitea.com/actions/gitea-release-action@v1
+        with:
+          name: Kordophone GTK ${{ env.RELEASE_VERSION }}
+          tag_name: ${{ github.ref_name }}
+          target_commitish: ${{ github.sha }}
+          files: |
+            ${{ env.RELEASE_ASSETS_DIR }}/*.rpm

.gitignore

@@ -1,2 +1,3 @@
+.codex
 ext/
 target/

core/Dockerfile

@@ -1,4 +1,4 @@
-FROM fedora:40
+FROM fedora:43
 
 RUN dnf update -y && \
     dnf install -y \
@@ -23,4 +23,3 @@ WORKDIR /workspace
 COPY . .
 
 CMD ["make", "rpm"]
-

core/kordophoned/Cargo.toml

@@ -1,6 +1,6 @@
 [package]
 name = "kordophoned"
-version = "1.3.0"
+version = "1.3.2"
 edition = "2021"
 license = "GPL-3.0"
 description = "Client daemon for the Kordophone chat protocol"

gtk/Dockerfile

@@ -1,4 +1,4 @@
-FROM fedora:40
+FROM fedora:43
 
 # Install RPM build tools and dependencies
 RUN dnf update -y && dnf install -y \

gtk/Makefile

@@ -5,14 +5,20 @@ all: setup
 setup: build/
 	meson build
 
-VER_RAW := $(shell git -C .. describe --tags --abbrev=0 2>/dev/null || git -C .. describe --tags 2>/dev/null || printf '0.0.0')
+VER_RAW := $(shell git -C .. describe --tags --match 'release/gtk/*' --abbrev=0 2>/dev/null || true)
-VER := $(patsubst v%,%,$(VER_RAW))
+VER := $(patsubst release/gtk/%,%,$(VER_RAW))
 TMP := $(shell mktemp -d)
-rpm:
+RPM_SOURCE := $(TMP)/$(VER).tar.gz
-	git -C .. archive --format=tar.gz --prefix=kordophone/ -o $(TMP)/v$(VER).tar.gz HEAD
+.PHONY: check-version
+check-version:
+	@test -n "$(VER_RAW)" || { echo "Could not determine GTK release version from git tags." >&2; echo "Expected a tag reachable from HEAD matching release/gtk/<version>." >&2; exit 1; }
+	@test "$(VER)" != "$(VER_RAW)" || { echo "Invalid GTK release tag: $(VER_RAW)" >&2; echo "Expected format: release/gtk/<version>." >&2; exit 1; }
+
+rpm: check-version
+	git -C .. archive --format=tar.gz --prefix=kordophone/ -o $(RPM_SOURCE) HEAD
 	rpmbuild -ba dist/rpm/kordophone.spec --define "_sourcedir $(TMP)" --define "app_version $(VER)"
 
-deb:
+deb: check-version
 	./dist/deb/build-deb.sh $(VER)
 
 .PHONY: flatpak

gtk/dist/rpm/kordophone.spec

@@ -5,7 +5,7 @@ Summary:        GTK4/Libadwaita client for Kordophone
 
 License:        GPL
 URL:            https://code.buzzert.dev/buzzert/Kordophone
-Source0:        %{url}/archive/v%{version}.tar.gz
+Source0:        %{url}/archive/release/gtk/%{version}.tar.gz
 
 BuildRequires:  meson >= 0.56.0
 BuildRequires:  vala

gtk/src/transcript/transcript-drawing-area.vala

@@ -383,6 +383,10 @@ private class TranscriptDrawingArea : Widget
                 items.add(image_layout);
             }
 
+            // New-message animation is a one-shot effect. Clear the flag after
+            // scheduling bubble animations so later relayouts do not replay it.
+            message.should_animate = false;
+
             last_sender = message.sender;
             last_date = date;