Private
Public Access
1
0

xpc: hacky implementation of GetVersion

This commit is contained in:
2025-08-10 21:48:44 -07:00
parent 911454aafb
commit e9bda39d8a
7 changed files with 291 additions and 38 deletions

13
kordophoned/README.md Normal file
View File

@@ -0,0 +1,13 @@
# kordophoned
The daemon executable that exposes an IPC interface (Dbus on Linux, XPC on macoS) to the client.
## Running on macOS
Before any client can talk to the kordophone daemon on macOS, the XPC service needs to be manually registered with launchd.
- Copy `include/net.buzzert.kordophonecd.plist` to `~/Library/LaunchAgents` (note the `ProgramArguments` key/value).
- Register using `launchctl load ~/Library/LaunchAgents/net.buzzert.kordophonecd.plist`

View File

@@ -0,0 +1,29 @@
<?xml version="1.0" encoding="UTF-8"?>
<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
<plist version="1.0">
<dict>
<key>Label</key>
<string>net.buzzert.kordophonecd</string>
<key>ProgramArguments</key>
<array>
<string>/Users/buzzert/src/kordophone-rs/target/debug/kordophoned</string>
</array>
<key>MachServices</key>
<dict>
<key>net.buzzert.kordophonecd</key>
<true/>
</dict>
<key>RunAtLoad</key>
<true/>
<key>KeepAlive</key>
<true/>
<key>StandardOutPath</key>
<string>/tmp/kordophoned.out.log</string>
<key>StandardErrorPath</key>
<string>/tmp/kordophoned.err.log</string>
</dict>
</plist>

View File

@@ -1,6 +1,14 @@
use crate::daemon::{events::Event, signals::Signal, DaemonResult};
use crate::xpc::interface::SERVICE_NAME;
use futures_util::StreamExt;
use std::collections::HashMap;
use std::ffi::CString;
use std::sync::Arc;
use tokio::sync::{mpsc, oneshot, Mutex};
use xpc_connection::{Message, MessageError, XpcClient, XpcListener};
static LOG_TARGET: &str = "xpc";
/// XPC IPC agent that forwards daemon events and signals over libxpc.
#[derive(Clone)]
@@ -18,9 +26,33 @@ impl XpcAgent {
}
}
/// Run the XPC agent: perform a basic GetVersion IPC call to the daemon and print the result.
/// Run the XPC agent and host the XPC service. Implements `GetVersion`.
pub async fn run(self) {
todo!()
log::info!(target: LOG_TARGET, "XPCAgent running");
// Construct the Mach service name without a trailing NUL for CString.
let service_name = SERVICE_NAME.trim_end_matches('\0');
let mach_port_name = match CString::new(service_name) {
Ok(c) => c,
Err(e) => {
log::error!(target: LOG_TARGET, "Invalid XPC service name: {e}");
return;
}
};
log::info!(
target: LOG_TARGET,
"Waiting for XPC connections on {}",
service_name
);
let mut listener = XpcListener::listen(&mach_port_name);
while let Some(client) = listener.next().await {
tokio::spawn(handle_client(client));
}
log::info!(target: LOG_TARGET, "XPC listener shutting down");
}
/// Send an event to the daemon and await its reply.
@@ -36,3 +68,80 @@ impl XpcAgent {
rx.await.map_err(|_| "Failed to receive reply".into())
}
}
async fn handle_client(mut client: XpcClient) {
log::info!(target: LOG_TARGET, "New XPC connection");
while let Some(message) = client.next().await {
match message {
Message::Error(MessageError::ConnectionInterrupted) => {
log::warn!(target: LOG_TARGET, "XPC connection interrupted");
}
Message::Dictionary(map) => {
// Try keys "method" or "type" to identify the call.
let method_key = CString::new("method").unwrap();
let type_key = CString::new("type").unwrap();
let maybe_method = map
.get(&method_key)
.or_else(|| map.get(&type_key))
.and_then(|v| match v {
Message::String(s) => Some(s.to_string_lossy().into_owned()),
_ => None,
});
match maybe_method.as_deref() {
Some("GetVersion") => {
let mut reply: HashMap<CString, Message> = HashMap::new();
reply.insert(
CString::new("type").unwrap(),
Message::String(CString::new("GetVersionResponse").unwrap()),
);
reply.insert(
CString::new("version").unwrap(),
Message::String(CString::new(env!("CARGO_PKG_VERSION")).unwrap()),
);
client.send_message(Message::Dictionary(reply));
}
Some(other) => {
log::warn!(target: LOG_TARGET, "Unknown XPC method: {}", other);
let mut reply: HashMap<CString, Message> = HashMap::new();
reply.insert(
CString::new("type").unwrap(),
Message::String(CString::new("Error").unwrap()),
);
reply.insert(
CString::new("error").unwrap(),
Message::String(CString::new("UnknownMethod").unwrap()),
);
reply.insert(
CString::new("message").unwrap(),
Message::String(CString::new(other).unwrap_or_else(|_| CString::new("").unwrap())),
);
client.send_message(Message::Dictionary(reply));
}
None => {
log::warn!(target: LOG_TARGET, "XPC message missing method/type");
let mut reply: HashMap<CString, Message> = HashMap::new();
reply.insert(
CString::new("type").unwrap(),
Message::String(CString::new("Error").unwrap()),
);
reply.insert(
CString::new("error").unwrap(),
Message::String(CString::new("InvalidRequest").unwrap()),
);
client.send_message(Message::Dictionary(reply));
}
}
}
other => {
// For now just echo any non-dictionary messages (useful for testing).
log::info!(target: LOG_TARGET, "Echoing message: {:?}", other);
client.send_message(other);
}
}
}
log::info!(target: LOG_TARGET, "XPC connection closed");
}

View File

@@ -1,6 +1,3 @@
#![cfg(target_os = "macos")]
//! macOS XPC IPC interface modules.
pub mod agent;
pub mod endpoint;
pub mod interface;