BrowserViewController: break up into extensions

App/Browser View/BrowserViewController.swift

@@ -9,23 +9,21 @@ import Combine
 import UIKit
 import UniformTypeIdentifiers
 
-class BrowserViewController: UIViewController, WKNavigationDelegate, WKUIDelegate, ScriptPolicyViewControllerDelegate,
-                             UIPopoverPresentationControllerDelegate, TabDelegate, TabPickerViewControllerDelegate,
-                             AutocompleteViewControllerDelegate, ShortcutResponder
+class BrowserViewController: UIViewController
 {
     let browserView = BrowserView()
     var tab: Tab { didSet { didChangeTab(tab) } }
     var webView: WKWebView { tab.webView }
     
-    private let tabController = TabController()
-    private let tabBarViewController: TabBarViewController
-    private let toolbarController = ToolbarViewController()
-    private let findOnPageController = FindOnPageViewController()
+    internal let tabController = TabController()
+    internal let tabBarViewController: TabBarViewController
+    internal let toolbarController = ToolbarViewController()
+    internal let findOnPageController = FindOnPageViewController()
     
-    private let autocompleteViewController = AutocompleteViewController()
-    private let redirectRules = PersonalRedirectRules()
+    internal let autocompleteViewController = AutocompleteViewController()
+    internal let redirectRules = PersonalRedirectRules()
     
-    private var policyManager: ResourcePolicyManager { tabController.policyManager }
+    internal var policyManager: ResourcePolicyManager { tabController.policyManager }
     
     override var canBecomeFirstResponder: Bool { true }
     
@@ -36,10 +34,10 @@ class BrowserViewController: UIViewController, WKNavigationDelegate, WKUIDelegat
     private var activeTabObservation: AnyCancellable?
     private var faviconObservation: AnyCancellable?
     
-    private var loadError: Error?
+    internal var loadError: Error?
     
-    private var commandKeyHeld: Bool = false
-    private var windowButtonHeld: Bool {
+    internal var commandKeyHeld: Bool = false
+    internal var windowButtonHeld: Bool {
         get { toolbarController.newTabButton.isTracking }
         set { toolbarController.newTabButton.cancelTracking(with: nil) }
     }
@@ -305,7 +303,7 @@ class BrowserViewController: UIViewController, WKNavigationDelegate, WKUIDelegat
         self.view = browserView
     }
     
-    private func updateLoadProgress(forWebView webView: WKWebView) {
+    internal func updateLoadProgress(forWebView webView: WKWebView) {
         if let loadError = loadError {
             toolbarController.urlBar.loadProgress = .error(error: loadError)
         } else if webView.estimatedProgress == 1.0 {
@@ -315,7 +313,7 @@ class BrowserViewController: UIViewController, WKNavigationDelegate, WKUIDelegat
         }
     }
     
-    private func updateTitleAndURL(forWebView webView: WKWebView) {
+    internal func updateTitleAndURL(forWebView webView: WKWebView) {
         if webView == browserView.webView {
             browserView.titlebarView.setTitle(webView.title ?? "")
             
@@ -403,33 +401,7 @@ class BrowserViewController: UIViewController, WKNavigationDelegate, WKUIDelegat
         toolbarController.traitCollectionDidChange(previousTraitCollection)
     }
     
-    private func updateCommandKeyState(forPresses presses: Set<UIPress>) {
-        guard let press = presses.first else { return }
-        
-        if let key = press.key {
-            if key.modifierFlags == [.command] {
-                let isDown = press.phase == .began || press.phase == .changed || press.phase == .stationary
-                self.commandKeyHeld = isDown
-            }
-        }
-    }
-    
-    override func pressesBegan(_ presses: Set<UIPress>, with event: UIPressesEvent?) {
-        super.pressesBegan(presses, with: event)
-        updateCommandKeyState(forPresses: presses)
-    }
-    
-    override func pressesCancelled(_ presses: Set<UIPress>, with event: UIPressesEvent?) {
-        super.pressesCancelled(presses, with: event)
-        updateCommandKeyState(forPresses: presses)
-    }
-    
-    override func pressesEnded(_ presses: Set<UIPress>, with event: UIPressesEvent?) {
-        super.pressesEnded(presses, with: event)
-        updateCommandKeyState(forPresses: presses)
-    }
-    
-    private func updateScriptBlockerButton() {
+    internal func updateScriptBlockerButton() {
         var numBlockedScripts: Int = tab.blockedScriptOrigins.count
         if tab.url != nil, tab.javaScriptEnabled == false {
             // Because the page is blocked too, notify.
@@ -451,158 +423,46 @@ class BrowserViewController: UIViewController, WKNavigationDelegate, WKUIDelegat
         let newTab = tabController.createNewTab(url: url)
         self.tab = newTab
     }
-        
-    // MARK: UIPopoverPresentationControllerDelegate
-    
+}
+
+extension BrowserViewController: UIPopoverPresentationControllerDelegate
+{
     func adaptivePresentationStyle(for controller: UIPresentationController, traitCollection: UITraitCollection) -> UIModalPresentationStyle {
         // Forces popovers to present on iPhone
         return .none
     }
-    
-    // MARK: Navigation Delegate
-    
-    func webView(_ webView: WKWebView, didStartProvisionalNavigation navigation: WKNavigation!) {
-        loadError = nil
-        
-        // Check to make sure we have connected to the web content process
-        if !tab.bridge.webContentProcessConnected {
-            // This means we started loading a page but the web content process hasn't loaded, which means
-            // scripts are not getting blocked.
-            
-            // If you're ad-hoc signing this, you'll need to disable library validation:
-            // sudo defaults write /Library/Preferences/com.apple.security.libraryvalidation DisableLibraryValidation -bool YES
-            
-            DispatchQueue.main.async { [unowned self] in
-                // Stop loading now
-                webView.stopLoading()
-                
-                // Show an alert
-                let alert = UIAlertController(title: "Web Process Not Loaded",
-                                              message: "The web content process never contacted the host application",
-                                              preferredStyle: .alert)
-                alert.addAction(UIAlertAction(title: "OK", style: .default, handler: { _ in
-                    alert.dismiss(animated: true, completion: nil)
-                }))
-                
-                present(alert, animated: true, completion: nil)
-            }
-        }
-        
-        // Reset tracking this
-        tab.allowedScriptOrigins.removeAll()
-        tab.blockedScriptOrigins.removeAll()
-        updateScriptBlockerButton()
-        
-        // Blur url bar if applicable
-        toolbarController.urlBar.textField.resignFirstResponder()
-        
-        updateTitleAndURL(forWebView: webView)
-        
-        if let url = webView.url {
-            // Start requesting favicon
-            tab.updateFaviconForURL(url)
-        }
+}
+
+extension BrowserViewController: ScriptPolicyViewControllerDelegate
+{
+    func didChangeScriptPolicy() {
+        tab.bridge.policyDataSourceDidChange()
+        webView.reload()
     }
     
-    func webView(_ webView: WKWebView, didFinish navigation: WKNavigation!) {
-        toolbarController.urlBar.loadProgress = .complete
-        
-        // Update history
-        if let url = webView.url {
-            let title = webView.title ?? ""
-            BrowserHistory.shared.didNavigate(toURL: url, title: title)
-        }
+    func setScriptsEnabledForTab(_ enabled: Bool) {
+        tab.javaScriptEnabled = enabled
+        toolbarController.scriptControllerIconView.shieldsDown = enabled
     }
-    
-    func webView(_ webView: WKWebView, decidePolicyFor navigationAction: WKNavigationAction, preferences: WKWebpagePreferences, decisionHandler: @escaping (WKNavigationActionPolicy, WKWebpagePreferences) -> Void)
-    {
-        // Handle command+click
-        if (commandKeyHeld || windowButtonHeld) && navigationAction.navigationType == .linkActivated {
-            // Cancel navigation in this tab
-            decisionHandler(.cancel, preferences)
-            
-            // Start navigation in a new tab
-            let tab = tabController.createNewTab(url: navigationAction.request.url)
-            self.tab = tab
-            
-            // Reset this flag.
-            commandKeyHeld = false
-            windowButtonHeld = false
-            
-            return
-        }
-        
-        var allowJavaScript = tab.javaScriptEnabled
-        if !allowJavaScript, let host = navigationAction.request.url?.host {
-            // Check origin policy
-            allowJavaScript = policyManager.allowedOriginsForScriptResources().contains(host)
-        }
-        
-        preferences.allowsContentJavaScript = allowJavaScript
-        
-        if let url = navigationAction.request.url,
-           let redirectedURL = redirectRules.redirectedURL(for: url)
-        {
-            tab.beginLoadingURL(redirectedURL)
-            decisionHandler(.cancel, preferences)
-        } else {
-            decisionHandler(.allow, preferences)
-        }
+}
+
+extension BrowserViewController: AutocompleteViewControllerDelegate
+{
+    func autocompleteController(_: AutocompleteViewController, didSelectHistoryItem item: HistoryItem) {
+        tab.beginLoadingURL(item.url)
+        autocompleteViewController.view.isHidden = true
     }
-    
-    func webView(_ webView: WKWebView, didFail navigation: WKNavigation!, withError error: Error) {
-        self.loadError = error
-    }
-    
-    func webView(_ webView: WKWebView, didFailProvisionalNavigation navigation: WKNavigation!, withError error: Error) {
-        self.loadError = error
-    }
-    
-    // MARK: WKUIDelegate
-    
-    func webView(_ webView: WKWebView, createWebViewWith configuration: WKWebViewConfiguration, for navigationAction: WKNavigationAction, windowFeatures: WKWindowFeatures) -> WKWebView?
-    {
-        let newTab = tabController.createNewTab(url: nil, webViewConfiguration: configuration)
-        newTab.webView.load(navigationAction.request)
-        
-        self.tab = newTab
-        
-        return newTab.webView
-    }
-    
-    func webView(_ webView: WKWebView, contextMenuConfigurationForElement elementInfo: WKContextMenuElementInfo, completionHandler: @escaping (UIContextMenuConfiguration?) -> Void) {
-        let menuConfig = UIContextMenuConfiguration(identifier: nil,
-                                                    previewProvider: nil) { (menuElements: [UIMenuElement]) -> UIMenu? in
-            
-            let openInNewTab = UIAction(title: "Open in New Tab",
-                                        image: UIImage(systemName: "plus.app"),
-                                        identifier: nil,
-                                        discoverabilityTitle: nil,
-                                        attributes: [],
-                                        state: .off) { [unowned self] _ in
-                let newTab = tabController.createNewTab(url: elementInfo.linkURL)
-                self.tab = newTab
-            }
-            
-            
-            return UIMenu(title: elementInfo.linkURL?.absoluteString ?? "Link",
-                          image: nil,
-                          identifier: nil,
-                          options: .displayInline,
-                          children: [ openInNewTab ] + menuElements)
-        }
-        
-        completionHandler(menuConfig)
-    }
-        
-    // MARK: Tab Delegate
-    
+}
+
+extension BrowserViewController: TabDelegate
+{
     func didBlockScriptOrigin(_ origin: String, forTab: Tab) {
         updateScriptBlockerButton()
     }
-    
-    // MARK: Tab Picker Delegate
-    
+}
+
+extension BrowserViewController: TabPickerViewControllerDelegate
+{
     func tabPicker(_ picker: TabPickerViewController, didSelectTab tab: Tab) {
         self.tab = tab
         picker.dismiss(animated: true, completion: nil)
@@ -614,90 +474,6 @@ class BrowserViewController: UIViewController, WKNavigationDelegate, WKUIDelegat
             picker.dismiss(animated: true, completion: nil)
         }
     }
-    
-    // MARK: Script Policy View Controller Delegate
-    
-    func didChangeScriptPolicy() {
-        tab.bridge.policyDataSourceDidChange()
-        webView.reload()
-    }
-    
-    func setScriptsEnabledForTab(_ enabled: Bool) {
-        tab.javaScriptEnabled = enabled
-        toolbarController.scriptControllerIconView.shieldsDown = enabled
-    }
-    
-    // MARK: Autocomplete Controller Delegate
-    
-    func autocompleteController(_: AutocompleteViewController, didSelectHistoryItem item: HistoryItem) {
-        tab.beginLoadingURL(item.url)
-        autocompleteViewController.view.isHidden = true
-    }
-    
-    // MARK: Keyboard shortcuts
-    
-    func focusURLBar(_ sender: Any?) {
-        toolbarController.urlBar.textField.becomeFirstResponder()
-    }
-    
-    func goBack(_ sender: Any?) {
-        tab.webView.goBack()
-    }
-    
-    func goForward(_ sender: Any?) {
-        tab.webView.goForward()
-    }
-    
-    func createTab(_ sender: Any?) {
-        createNewTab(withURL: nil)
-    }
-    
-    func previousTab(_ sender: Any?) {
-        if let tabIndex = tabController.tabs.firstIndex(of: self.tab) {
-            if tabIndex - 1 >= 0 {
-                self.tab = tabController.tabs[tabIndex - 1]
-            }
-        }
-    }
-    
-    func nextTab(_ sender: Any?) {
-        if let tabIndex = tabController.tabs.firstIndex(of: self.tab) {
-            if tabIndex + 1 < tabController.tabs.count {
-                self.tab = tabController.tabs[tabIndex + 1]
-            }
-        }
-    }
-    
-    func closeTab(_ sender: Any?) {
-        if tabController.tabs.count > 1 {
-            tabController.closeTab(self.tab)
-        } else {
-            #if targetEnvironment(macCatalyst)
-            if let originWindowScene = self.view.window?.windowScene {
-                UIApplication.shared.requestSceneSessionDestruction(originWindowScene.session, options: nil) { error in
-                    print("Error when requesting scene destruction: " + error.localizedDescription)
-                }
-            }
-            #endif
-        }
-    }
-    
-    func findOnPage(_ sender: Any?) {
-        browserView.setFindOnPageVisible(true, animated: true)
-        findOnPageController.findOnPageView.textField.becomeFirstResponder()
-    }
-    
-    func refresh(_ sender: Any?) {
-        webView.reload()
-    }
-    
-    override func increaseSize(_ sender: Any?) {
-        tab.webView._viewScale += 0.10
-    }
-    
-    override func decreaseSize(_ sender: Any?) {
-        tab.webView._viewScale -= 0.10
-    }
 }
 
 extension BrowserViewController: UITextFieldDelegate